Move to vifaa dependency#335
Merged
Merged
Conversation
This module is merged into datastructures through an external dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Refactor the engine to consume core data structures and utility algorithms from the external
vifaapackage instead of maintaining duplicated internal implementations.Solution
The engine previously maintained its own implementations of foundational data structures and utility algorithms such as:
DenseListGraph/GraphListIndexAllocatorBitsetPoolArrayViewRangeThese implementations duplicated functionality that now exists in
vifaa. This migrates the engine tovifaa@0.3.0, removes the internal copies, and updates dependent systems to use the external package.Why this approach:
Showcase
N/A
Migration guide
Notes
vifaa.algorithmsmodule.vifaaequivalents where applicable.Checklist
The test checkbox is left unchecked because this PR removes the engine-owned datastructure tests and relies on the external
vifaapackage's test suite rather than adding new tests within this repository.